build: fix doCheckGenerate not print changed files
#33299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Fix bug
1.1 Issue
The function
doCheckGeneratedoes not print the changed files as expected because the functionHashFolderonly iterate the following path:..dockerignore.git.gitattributessthen exits.
1.2 Reason
After researching, I found the reason. The parameter
exludepassed to theHashFolderfunction contains the directory.git. Then, when thefilepath.WalkDirencounters the file.gitattributes, it returns the errorfilepath.SkipDirbecause the prefix contains..git.Due to encountering the error 'filepath.WalkDir' in the root directory, it immediately stopped.1.3 how to fix
return right error
filepath.SkipDirif it is an excluded directoryhandle directory
.githubSince the directory
.githubhas prefix.git, so we use equal to check if it is an excluded path.2. Optimize code
Move 'filepath. FromSlash' from function 'HashFolder' to function 'doCheckGenerate', reducing the number of calls from 18000 to 3 times.
3. Fix typos
Change
exludetoexcludes.